[ 
https://issues.apache.org/jira/browse/VCL-702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14240145#comment-14240145
 ] 

ASF subversion and git services commented on VCL-702:
-----------------------------------------------------

Commit 1644202 from [~arkurth] in branch 'vcl/trunk'
[ https://svn.apache.org/r1644202 ]

VCL-702
More sloppy code cleanup.  The backend code contains over 1,200 subroutines 
with all lowercase names. Why do subroutines with uppercase letters keep 
popping up? Renamed the following subroutines:

OS.pm
server_request_set_fixedIP > server_request_set_fixed_ip
confirm_fixedIP_is_available > confirm_fixed_ip_is_available
update_fixedIP_info > update_fixed_ip_info

DataStructure.pm
get_next_image_dataStructure > get_next_image_data_structure

blockrequest.pm
update_blockTimes_processing > update_block_times_processing
clear_blockTimes > clear_block_times
clear_blockComputers > clear_block_computers

vbox.pm
control_VM > control_vm

utils.pm
notify_via_IM > notify_via_im
get_current_image_contents_noDS > get_current_image_contents_no_data_structure

> Rework code to use new subroutines and objects & general code cleanup
> ---------------------------------------------------------------------
>
>                 Key: VCL-702
>                 URL: https://issues.apache.org/jira/browse/VCL-702
>             Project: VCL
>          Issue Type: Improvement
>          Components: vcld (backend)
>    Affects Versions: 2.3
>            Reporter: Andy Kurth
>            Assignee: Andy Kurth
>            Priority: Minor
>             Fix For: 2.4
>
>
> There are various places in the code where some old code is being used which 
> can be replaced with newer improved code.  This issue is a catch-all for 
> these.
> Examples:
> run_ssh_command -> $self->execute
> code_loop_timeout
> ALL PLACES WHERE 'GOTO' IS USED!



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to