[
https://issues.apache.org/jira/browse/VCL-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14182863#comment-14182863
]
ASF subversion and git services commented on VCL-776:
-----------------------------------------------------
Commit 1634070 from [~jfthomps] in branch 'vcl/trunk'
[ https://svn.apache.org/r1634070 ]
VCL-780 - combine new reservation and current reservations pages
VCL-776 - rework resource code to have a base class for all resources and
inheriting classes for each resource type
requests.php: modified viewRequests: moved commands that run when "I do not
agree" button clicked to a function connected to when the dialog is hidden
resource.php: modified AJstartImage: tell getImageRevisions to included deleted
revisions when getting data; helps to handle case where a capture has already
started which would have the deleted flag set on the image revision
image.js: created hideClickThroughDlg: this is called when clickthrough dialog
is hidden; there was a problem where the circle/X button could be clicked to
hide the dialog which would leave the comments dialog open; clicking the Submit
button in that dialog at this point caused the request to be updated to the
imaging state and a new entry created in the imagerevision table; moving things
to run when the dialog is hidden causes thing to properly get cleared/cleaned
up when the circle/X button is clicked instead of the "I do not agree" button
> rework resource code to have a base class for all resources and inheriting
> classes for each resource type
> ---------------------------------------------------------------------------------------------------------
>
> Key: VCL-776
> URL: https://issues.apache.org/jira/browse/VCL-776
> Project: VCL
> Issue Type: Improvement
> Components: web gui (frontend)
> Reporter: Josh Thompson
> Fix For: 2.4
>
>
> Rework the code for resources so that there is a base class that provides
> common functionality for all resources and then write classes that inherit
> from that to provide resource specific functionality.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
