[
https://issues.apache.org/jira/browse/VCL-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14202541#comment-14202541
]
ASF subversion and git services commented on VCL-776:
-----------------------------------------------------
Commit 1637437 from [~jfthomps] in branch 'vcl/trunk'
[ https://svn.apache.org/r1637437 ]
VCL-776 - rework resource code to have a base class for all resources and
inheriting classes for each resource type
resource.php: modified AJstartImage: use $revid for value of
$cdata['baserevisionid'] instead of getting it from $data['reservations']
image.php:
-modified createImage: get imageid from continuation instead of from request
data; get baerevisionid from continuation instead of from request data. I was
seeing a few problems where AJsaveResource was somehow getting submitted twice
with the 2nd time using the imagerevisionid from the newly created image
-modified validateResourceData: include baserevisionid in returned data
errors.php: changed references to addImage to "Image::addResource"
image.js:
-modified saveResourceCB, updateImageCB, and submitUpdateImageClickthroughCB:
enable clickthroughDlgBtn after hiding clickthroughdlg
-modified clickThroughAgree: disable clickthroughDlgBtn when it is clicked so
it cannot be double clicked
-modified hideClickThroughDlg: check to see if each dialog is open before
calling .hide() on it
> rework resource code to have a base class for all resources and inheriting
> classes for each resource type
> ---------------------------------------------------------------------------------------------------------
>
> Key: VCL-776
> URL: https://issues.apache.org/jira/browse/VCL-776
> Project: VCL
> Issue Type: Improvement
> Components: web gui (frontend)
> Reporter: Josh Thompson
> Fix For: 2.4
>
>
> Rework the code for resources so that there is a base class that provides
> common functionality for all resources and then write classes that inherit
> from that to provide resource specific functionality.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
