[ 
http://issues.apache.org/jira/browse/VELOCITY-502?page=comments#action_12454266 
] 
            
Claude Brisson commented on VELOCITY-502:
-----------------------------------------

Le mardi 28 novembre 2006 à 12:14 -0800, Henning Schmiedehausen (JIRA) a écrit :
> I tried ant -Dforce.jar.loading=1 and force.jar.loading=0 with no success 
> until I found out that it's -Dforce.jar.loading=true that works.

Ant properties allow "on","true" and "yes", but not 1... I guess you should not 
play lotto this week.

> [...]
> check ---> Current behaviour. Check for presence, if missing download, if 
> existing, check timestamp.
> 

Are you sure you want to keep this one? There is no point in checking 
timestamps of versionned filenames.

> [...]
> But I don't want to have a second (different named, booo!) property whose 
> semantics are different
> from skip.jar.loading (here, presence is enough, for the proposed change the 
> property must actually
> contain the 'True' value) which muddles the options that an user must go 
> through.

I agree that the semantics should be the same, good point (I hadn't noticed 
this behaviour of the "unless" attribute). But I'd rather have skip.jar.loading 
semantics modified, because having the property "skip.jar.loading=false" still 
skiping jar loading looks rather confusing.

Also, your proposal seems much more difficult to document, whereas just putting 

        skip.jar.loading = false
        force.jar.loading = false
        
inside build.properties is straightforward to anybody taking a look at the file.



> Skip jar verification unless "force.jar.loading" is true
> --------------------------------------------------------
>
>                 Key: VELOCITY-502
>                 URL: http://issues.apache.org/jira/browse/VELOCITY-502
>             Project: Velocity
>          Issue Type: Improvement
>          Components: Build
>    Affects Versions: 1.5 beta2
>         Environment: all
>            Reporter: Claude Brisson
>            Priority: Minor
>             Fix For: 1.5
>
>         Attachments: jar-downloading.patch
>
>
> When the www.iblibo.org/maven repository is down (as it seems right now, at 
> least from here), or when you want to work form an unconnected place (yes, it 
> still exists...), build fails because ant wants to check every jar timestamp.
> The attached patch modifies this behaviour: if a jar file is already present, 
> the repository is not hit at all (why would we have to check any timestamp 
> anyway since version numbers are present inside filenames?!).
> The new force.jar.loading property forces reloading of jar files.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to