[ 
http://issues.apache.org/jira/browse/VELOCITY-502?page=comments#action_12460649 
] 
            
Claude Brisson commented on VELOCITY-502:
-----------------------------------------

So what do we do here?

We have two proposals:

1.Henning's proposal:
  velocity.jar.loading = never / once / check / always
(where the utility of "check" is questionnable, that would let us with "never / 
once / always")

2. mine:
  skip.jar.loading = true / false
  force.jar.loading = true / false
(including changing the rather strange current behaviour of skip.jar.loading, 
which is to have an effect even when set with the value "false"...)

Both are probably acceptable, and Henning's proposal is maybe more rigoureous 
(one parameter controlling one behaviour),
mine is maybe more self-explanatory (but allows the strange mode skip=true & 
force=true, where one will discover that skip has the precedence, do we
really care, sometimes we loose ourselves in details, it's incredible).

Veltools has already made a step towards option 2 (but it is not irreversible). 
I'd just like to close this trivial issue. Option 2 is also a little easier to 
implement in ant. Thoughts? If nobody react here I'll commit in option 2.





> Skip jar verification unless "force.jar.loading" is true
> --------------------------------------------------------
>
>                 Key: VELOCITY-502
>                 URL: http://issues.apache.org/jira/browse/VELOCITY-502
>             Project: Velocity
>          Issue Type: Improvement
>          Components: Build
>    Affects Versions: 1.5 beta2
>         Environment: all
>            Reporter: Claude Brisson
>            Priority: Minor
>             Fix For: 1.5
>
>         Attachments: jar-downloading.patch
>
>
> When the www.iblibo.org/maven repository is down (as it seems right now, at 
> least from here), or when you want to work form an unconnected place (yes, it 
> still exists...), build fails because ant wants to check every jar timestamp.
> The attached patch modifies this behaviour: if a jar file is already present, 
> the repository is not hit at all (why would we have to check any timestamp 
> anyway since version numbers are present inside filenames?!).
> The new force.jar.loading property forces reloading of jar files.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to