Nice work!  Some notes:

The pom.xml file lists "1.4-dev" as the version.  Would it be worth it to
re-roll the release and keep the maven mavens happy?

No big deal, but if we did re-roll it, we should fix:
* readme.txt file has the old URL for Velocity, not the new one.
* readme has the old email list addresses.
* the readme.txt has conflicting info on required JDK for building.  On line
32 it claims a min of  1.3.1.  Line 75 says 1.4.  But actually it requires
1.5 (or so ant tells me).

I ran "ant test" under JDK 1.4 (failed with appropriate error message), JDK
1.5 (worked) and JDK 1.6 (worked).

I'm -0 due to the pom issue but would flip to +1 if someone tells me this is
ok or it's fixed.

WILL

On Nov 15, 2007 7:38 AM, Christopher Schultz <[EMAIL PROTECTED]>
wrote:

> Nathan,
>
> Nathan Bubna wrote:
> > The test build for this release is available at:
> > http://people.apache.org/~nbubna/velocity/tools/1.4/<http://people.apache.org/%7Enbubna/velocity/tools/1.4/>
> >
> > Please vote regarding your support for releasing this test build as
> > VelocityTools 1.4:
> >
> > [ ] +1 Let's do it
> > [ ] +0 Have fun; i don't care.
> > [ ] -0  Not sure about this, but i won't stop you.
> > [ ] -1 No, because __________________
>
> +1 - All the things I need are in there and work just fine ;)
>
> (Though I think I don't have any voting power...)
>
> Thanks for all the hard work, Nathan!
>
> -chris
>
>
>


-- 
Forio Business Simulations

Will Glass-Husain
[EMAIL PROTECTED]
www.forio.com

Reply via email to