[
https://issues.apache.org/jira/browse/VELOCITY-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12624540#action_12624540
]
Nathan Bubna commented on VELOCITY-467:
---------------------------------------
Most of the remaining places where an error is logged without an exception
thrown are in the various AST[MathOp]Node classes when one of the variables is
null.
I'm not sure we really want to start throwing exceptions in these cases, at
least not by default. These are not fatal errors; so throwing an exception
would be a break in backwards compatibility.
I think perhaps we ought to make this configurable, defaulting to log-only.
Also, we might want a new VelocityMathException or something like that, to
distinguish these.
> Throw more exceptions and log less errors
> -----------------------------------------
>
> Key: VELOCITY-467
> URL: https://issues.apache.org/jira/browse/VELOCITY-467
> Project: Velocity
> Issue Type: Improvement
> Components: Engine
> Affects Versions: 1.5 beta1
> Reporter: Will Glass-Husain
> Priority: Minor
> Fix For: 1.6
>
>
> Now that Velocity application exceptions are based on RuntimeException, we
> have more opportunity to use exceptions to signal application level problems.
> I'm particularly concerned about initialization problems that are logged and
> may be missed. We need to review all logged error messages and see if it
> would be more appropriate to throw an exception instead. Some of these
> places we may need to leave as is for backwards compatibility reasons. (e.g.
> macro in the global macro library doesn't parse properly).
> Llewellyn Falco made a good case for this on the dev list recently:
> http://www.mail-archive.com/[EMAIL PROTECTED]/msg15067.html
> #####
> I still would like to put in my vote that sending error's to the log is an
> incredibly BAD idea.
> If something is not working, it should be LOUDLY shown as an exception.
> If it is working I don't really need a log.
> The (velocity) log should be there for velocity developers (those programming
> the actual velocity code) not users.
> I don't ever care to see tomcat's log, I care to see the things I log while
> in tomcat.
> Most of all, many many many people do not check the log at all, let alone
> frequently.
> ####
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
