I think upping the JDK version is good and healthy. Are there any worries about JDK 1.8 changes in the Velocity code base? The main thing I have seen get messed up in our code bases are routines that use Maps/Hashmaps that expected things to be in the order added which changed in that jdk version.
https://docs.oracle.com/javase/8/docs/technotes/guides/collections/changes8.html -n On Fri, Feb 22, 2019 at 6:40 PM Claude Brisson <cla...@renegat.net.invalid> wrote: > Hi all. > > The VELOCITY-892 branch contains a fix for the corresponding issue [1]. > > The purpose is to let the method arguments conversion handler manipulate > the formal arguments types as java.lang.reflect.Type rather than > java.lang.Class, so that when dealing with a method like > > void foo(List<Integer> list) > > called with a string like "1,2,3", the conversion handler can choose the > correct converter between several string->list converters. > > But merging the VELOCITY-892 branch back to trunk requires a minimal jdk > version of 1.8 (because of the Type.getTypeName() method). > > Java SE 8 is now five years old, so I don't think it's a problem. > > Any objection? > > This would also involve raising the source and target versions to 1.8 > for consistency. > > [1] https://issues.apache.org/jira/projects/VELOCITY/issues/VELOCITY-892 > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org > For additional commands, e-mail: dev-h...@velocity.apache.org > > -- *Nate Chadwick • Vice President of Products & Services* (0) 781-835-1356 | (M) 781-835-8766 | nate_chadw...@percussion.com 600 Unicorn Park Drive, 2nd Floor | Woburn, MA 01801 | www.percussion.com *Follow us on Twitter @percussion <https://twitter.com/percussion>* <http://www.percussion.com/products/cm1/video-demo/index>
