michael-o commented on code in PR #43:
URL: https://github.com/apache/velocity-engine/pull/43#discussion_r1517530848
##########
velocity-custom-parser-example/pom.xml:
##########
@@ -140,7 +140,7 @@
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>javacc-maven-plugin</artifactId>
- <version>2.6</version>
+ <version>3.1.0</version>
Review Comment:
should be managed in the parent
##########
velocity-engine-core/src/main/java/org/apache/velocity/runtime/parser/node/ParserVisitor.java:
##########
@@ -1,332 +0,0 @@
-package org.apache.velocity.runtime.parser.node;
-
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied. See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-/**
- * Interface used in implementation of visitor pattern. Based on
- * code autogenerated by JavaCC. Formerly found in package
- * org.apache.velocity.runtime.parser.
- *
- * @version $Id$
- * @since 1.5
- */
-public interface ParserVisitor
Review Comment:
Upstream change?
##########
velocity-engine-core/pom.xml:
##########
@@ -108,7 +108,7 @@
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>javacc-maven-plugin</artifactId>
- <version>2.6</version>
+ <version>3.1.0</version>
Review Comment:
should be managed in the parent
##########
velocity-engine-core/src/main/java/org/apache/velocity/runtime/parser/node/ParserTreeConstants.java:
##########
@@ -1,24 +0,0 @@
-package org.apache.velocity.runtime.parser.node;
-
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied. See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-public interface ParserTreeConstants extends StandardParserTreeConstants
Review Comment:
Upstream change?
##########
velocity-custom-parser-example/pom.xml:
##########
@@ -209,34 +209,6 @@
</executions>
</plugin>
- <!-- add missing imports to some parser generated files -->
- <plugin>
- <groupId>com.google.code.maven-replacer-plugin</groupId>
- <artifactId>replacer</artifactId>
- <executions>
- <execution>
- <id>patch-parser-files</id>
- <phase>process-sources</phase>
- <goals>
- <goal>replace</goal>
- </goals>
- <configuration>
- <includes>
-
<include>${project.build.directory}/generated-sources/jjtree/**/JJT${parser.basename}ParserState.java</include>
-
<include>${project.build.directory}/generated-sources/jjtree/**/${parser.basename}ParserVisitor.java</include>
- </includes>
- <replacements>
- <replacement>
- <token>import ${parser.package}.*;</token>
- <value>import ${parser.package}.*;
-import org.apache.velocity.runtime.parser.node.*;</value>
- </replacement>
- </replacements>
- </configuration>
- </execution>
- </executions>
- </plugin>
-
Review Comment:
Why isn't this required anymore?
##########
velocity-engine-core/pom.xml:
##########
@@ -139,29 +138,6 @@
</executions>
</plugin>
- <!-- post-processing of parser genereted source files -->
- <plugin>
- <groupId>com.google.code.maven-replacer-plugin</groupId>
- <artifactId>replacer</artifactId>
- <executions>
- <execution>
- <id>patch-parser-files</id>
- <phase>process-sources</phase>
- <goals>
- <goal>replace</goal>
- </goals>
- <configuration>
-
<file>${project.build.directory}/generated-sources/javacc/org/apache/velocity/runtime/parser/TokenMgrError.java</file>
- <replacements>
- <replacement>
- <token>static final int</token>
- <value>public static final int</value>
- </replacement>
- </replacements>
- </configuration>
- </execution>
- </executions>
- </plugin>
Review Comment:
Why isn't this required anymore?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
For additional commands, e-mail: dev-h...@velocity.apache.org
