slachiewicz commented on code in PR #43: URL: https://github.com/apache/velocity-engine/pull/43#discussion_r1517540877
########## velocity-custom-parser-example/pom.xml: ########## @@ -209,34 +209,6 @@ </executions> </plugin> - <!-- add missing imports to some parser generated files --> - <plugin> - <groupId>com.google.code.maven-replacer-plugin</groupId> - <artifactId>replacer</artifactId> - <executions> - <execution> - <id>patch-parser-files</id> - <phase>process-sources</phase> - <goals> - <goal>replace</goal> - </goals> - <configuration> - <includes> - <include>${project.build.directory}/generated-sources/jjtree/**/JJT${parser.basename}ParserState.java</include> - <include>${project.build.directory}/generated-sources/jjtree/**/${parser.basename}ParserVisitor.java</include> - </includes> - <replacements> - <replacement> - <token>import ${parser.package}.*;</token> - <value>import ${parser.package}.*; -import org.apache.velocity.runtime.parser.node.*;</value> - </replacement> - </replacements> - </configuration> - </execution> - </executions> - </plugin> - Review Comment: No more neesed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For additional commands, e-mail: dev-h...@velocity.apache.org