Looks good. One quick comment, take a look at our code format and style guidelines. You can set up eclipse to format your code for you using our sister project's code format profile [1].
[1] http://vxquery.apache.org/development_eclipse_setup.html On Sat, Jun 13, 2015 at 11:03 AM, Michael Carey <[email protected]> wrote: > Very cool!! > > > On 6/13/15 9:38 AM, Efi wrote: > >> Hello everyone, >> >> The reading of a single document and a collection of documents from HDFS >> is completed and tested.New JUnit tests are added in the xtest project, >> they are just copies of the aggregate tests, that I changed a bit to run >> for the collection reading from HDFS. >> >> I added another option in the xtest in order for the HDFS tests to run >> successfully.It is a boolean option called /hdfs/ and it enables the tests >> for HDFS to run. >> >> You can view these in the branch /hdfs2_read/ in my github fork of >> vxquery. [1] >> >> I will continue with the parallel reading from HDFS. >> >> Best Regards, >> Efi >> >> [1] https://github.com/efikalti/vxquery/tree/hdfs2_read >> >> On 04/06/2015 08:50 μμ, Eldon Carman wrote: >> >>> We have a set of JUnit tests to validate VXQuery. I think it would be a >>> good idea to add test cases that validate the HDFS code your adding to >>> the >>> code base. Take a look at the vxquery-xtest sub-project. The VXQuery >>> Catalog holds all the vxquery test cases [1]. You could add a new HDFS >>> test >>> group to this list catalog. >>> >>> 1. >>> >>> https://github.com/apache/vxquery/blob/master/vxquery-xtest/src/test/resources/VXQueryCatalog.xml >>> >>> On Thu, Jun 4, 2015 at 10:26 AM, Efi <[email protected]> wrote: >>> >>> Hello everyone, >>>> >>>> This week Preston and Steven helped me with the vxquery code and >>>> specifically where my parser and two more functionalities will fit in >>>> the >>>> code. >>>> >>>> Along with the hdfs parallel parser that I have been working on these >>>> past >>>> weeks,two more methods will be implemented.They will both read whole >>>> files >>>> from hdfs and not just blocks.The one will read all the files located >>>> in a >>>> directory in hdfs and the other will read a single document. >>>> >>>> The reading of files from a directory is completed and for the next >>>> week I >>>> will focus on testing it and implementing/testing the second method, >>>> reading of a single document. >>>> >>>> Best regards, >>>> Efi >>>> >>>> >> >> >
