Thanks, Steven. A few questions on details :)
> On Jun 27, 2015, at 5:47 PM, Steven Jacobs <[email protected]> wrote: > > We are still experimenting with it but Preston and I are doing a code > review for Efi this week. This is the process as we have it now: > 1. Efi created a fork of master on her Github > 2. She creates a pull request (Efi we forgot this step can you create the > request on this one?) > 3. We use the pull request interface on Github to add comments to the code. When you do this, can you/do you also get the whole branch for the PR to be able to test it locally? > 4. Once the code is accepted it can be pushed to master How does that work? Do you (Steven) get the branch for the pull request, rebase it on the current master (if necessary), and push it back to the ASF repo manually? Or is there a better way to move it from GitHub to the ASF repo? I would like to put step-by-step instructions with paste-able command on the website. It was really helpful for me that Preston did those for the XQTS tests - and I think that other people might appreciate them as well :) Cheers, Till > On Saturday, June 27, 2015, Till Westmann <[email protected]> wrote: > >> Hi, >> >> I’ve started to work on https://issues.apache.org/jira/browse/VXQUERY-159 >> <https://issues.apache.org/jira/browse/VXQUERY-159> and I’d like to use >> this to understand out GitHub workflow (and potentially add it to the >> website). >> Could you tell me how you are using this so far (who branches what from >> where, where and how the review happens, and how the changes get merged >> back into the ASF repository)? >> >> Thanks, >> Till
