I looked at your pull request, I just had one comment: In the case where the author is a committer, shouldn't the author be the one who actually pushes to master? Or are we only doing code reviews for non-committers at this point?
Also, for anyone interested, Efi's pull request can be seen here: https://github.com/apache/vxquery/pull/16 These are the changes to enable collection and doc to allow HDFS directories. I have already done my first pass review, and Preston is going to review it as well. Steven On Mon, Jun 29, 2015 at 6:07 PM, Eldon Carman <[email protected]> wrote: > I started creating a website site page to outline the process. I created a > github pull request for reviewing the site changes. > > https://github.com/apache/vxquery/pull/18 > > On Sun, Jun 28, 2015 at 6:18 PM, Eldon Carman <[email protected]> wrote: > > > This process should be written up on our website. > > > > Things to note and could be added to this documentation: > > - The pull request should compare against the Apache VXQuery master > > branch. > > - The code must pass the VXQuery test suite and the previously passing > > XQTS tests. (We have pages to document these procedures.) > > - If the code improves the XQTS test suite performance, we can update > our > > local list of passing tests. (Also on our website.) > > > > On Sun, Jun 28, 2015 at 2:05 AM, Efi Kaltirimidou <[email protected]> > > wrote: > > > >> Yes I will do a pull request today after I make sure all the edited and > >> new > >> file has the correct format. > >> > >> Efi > >> On Jun 28, 2015 2:10 AM, "Till Westmann" <[email protected]> wrote: > >> > >> > Hi, > >> > > >> > I’ve started to work on > >> https://issues.apache.org/jira/browse/VXQUERY-159 > >> > <https://issues.apache.org/jira/browse/VXQUERY-159> and I’d like to > use > >> > this to understand out GitHub workflow (and potentially add it to the > >> > website). > >> > Could you tell me how you are using this so far (who branches what > from > >> > where, where and how the review happens, and how the changes get > merged > >> > back into the ASF repository)? > >> > > >> > Thanks, > >> > Till > >> > > > > >
