[
https://issues.apache.org/jira/browse/VXQUERY-67?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15182350#comment-15182350
]
Till Westmann commented on VXQUERY-67:
--------------------------------------
Thanks for creating this change.
I briefly looked at the code for fn:matches.
While it generally looks good, there is quite some replication in the
conversions of the UTF8 strings that should be factored out.
Also, it would be nice to use the code formatting guidelines linked in [1].
But more importantly what should be done is to run the XQTS testsuite [2] with
your changes and see
a) if the function implementations pass the tests for the functions and if
b) the change does not introduce new regressions wrt the materialized XQTS
results [3].
It would also be good if the change in the materialized results would be part
of the PR.
Does this help?
[1] http://vxquery.apache.org/development_eclipse_setup.html
[2] http://vxquery.apache.org/user_running_tests.html
[3] http://vxquery.apache.org/development_update_xqts_results.html
> Functions Missing for "String Functions that Use Pattern Matching"
> ------------------------------------------------------------------
>
> Key: VXQUERY-67
> URL: https://issues.apache.org/jira/browse/VXQUERY-67
> Project: VXQuery
> Issue Type: Sub-task
> Reporter: Preston Carman
> Assignee: Preston Carman
> Labels: starter
>
> The following functions are missing:
> fn:matches
> fn:replace
> fn:tokenize
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
