Hi,
I took a brief look into you change and here are a few next steps that
could
help to get a better handle on the issue:
1) One of the problems with the diff for the expected results is, that
the
instructions to create the diff that you find on the website are not
consistent with the current reality [1]. So one good step would be
to
a) recreate the expected results with an unmodified checkout
following
the instructions on the website and
b) checking that only the order has changed, and
c) creating a PR for that.
2) Rerun the tests with your patch, categorize the failures by stack
trace,
and explain at least one failure in more detail on the list (with a
stack trace, pointers to the code an possible explanations - if they
come to mind). E.g. it would be good to see in the e-mail what the
system did when the creation of a sequence for fn:tokenize didn’t
work.
Does this make sense?
Cheers,
Till
[1] https://issues.apache.org/jira/browse/VXQUERY-187
On 11 Mar 2016, at 18:11, Riyafa Abdul Hameed wrote:
Hi,
I tried fixing the errors from the test results and I was unable to
fix
some of them. You can find the full error report here[1]. The test
cases
related this PR are from 13865 to 14054.
There are errors related to exception handling and since I am using
the
available java functions I am not sure how I could catch such errors.
Also I don't seem to be matching UTF-8 strings, I tried to get the
byte
array and convert to UTF-8 string, but it wouldn't work.
Related errors are: 13918 to 13921.
According to [2] I think we should convert all the UTF-8 characters as
appropriate when adding to a StringBuilder in the UTF8StringPointable
class.. I am not sure how I could do that.
Also I tried converting the result of fn:tokenize to a sequence of
strings
(using sequence builder) instead of a single string, but in vain.
Maybe I have understood things incorrectly. Can you please help me
figure
out how I could fix these errors?
(I sent a previous mail which was not delivered because I tried to
attach
the error report)
[1]
http://riyafa.github.io/Riyafa-Abdul-Hameed--web-page/others/full_report.html
[2] http://stackoverflow.com/a/5729843/3599535
Thank you.
Yours sincerely,
Riyafa
On 10 March 2016 at 14:04, Till Westmann <[email protected]> wrote:
Hi Riyafa,
I just looked at your PR [1] and realized that the diff in the
results
file is very big.
I think that this might be due to a recent commit by Preston [2] that
changed the sorting of the results file a bit.
Could you take a look if that’s indeed the case and - if so -
create a new
results file with the same order that’s currently checked it?
Otherwise, could you validate, that queries that use the new
functions
work correctly now?
Cheers,
Till
[1] https://github.com/apache/vxquery/pull/32/
[2]
https://github.com/apache/vxquery/commit/43852a5476ccb33bf9ee58e27468b400cc169d6a#diff-39476c050696c8ab9f59540b607ba92e
--
Riyafa Abdul Hameed
Undergraduate, University of Moratuwa
Email: [email protected]
Website: https://riyafa.wordpress.com/ <http://riyafa.wordpress.com/>
<http://facebook.com/riyafa.ahf> <http://lk.linkedin.com/in/riyafa>
<http://twitter.com/Riyafa1>
