The issue comes from null can be compared to all data types. I guess I would then remove the else statement since the if has a return statement and the code review will then only show the changes you made instead of indenting the whole switch statement.
On Mon, Jul 25, 2016 at 10:07 AM, Riyafa Abdul Hameed < [email protected]> wrote: > Hi, > > I added the tests for all comparison checks (eq, ne, lt, gt, ge, le) as > suggested[1]. Here I have used an if statement in the FunctionHelper > class instead of checking for null tag inside switch statements because it > would be tedious to add the null tag to all the switch statements for the > tid2 tag. Shall I proceed to attempt to add the null tag into all the > switch statements or leave it as a if check? > > [1] https://github.com/apache/vxquery/pull/109 > > Thank you. > > Yours sincerely, > Riyafa > > > On 19 July 2016 at 16:34, Riyafa Abdul Hameed <[email protected]> > wrote: > >> Hi, >> >> I have made Changes to value comparison semantics for JSONiq[1]. >> >> [1] https://github.com/apache/vxquery/pull/109 >> >> Thank you. >> >> Yours sincerely, >> Riyafa >> >> -- >> Riyafa Abdul Hameed >> Undergraduate, University of Moratuwa >> >> Email: [email protected] >> Website: https://riyafa.wordpress.com/ <http://riyafa.wordpress.com/> >> <http://facebook.com/riyafa.ahf> <http://lk.linkedin.com/in/riyafa> >> <http://twitter.com/Riyafa1> >> > > > > -- > Riyafa Abdul Hameed > Undergraduate, University of Moratuwa > > Email: [email protected] > Website: https://riyafa.wordpress.com/ <http://riyafa.wordpress.com/> > <http://facebook.com/riyafa.ahf> <http://lk.linkedin.com/in/riyafa> > <http://twitter.com/Riyafa1> >
