Please don't just add +1 on the vote.
As the PPMC voting we need to specify what we checked and what kind of
issue we still need to resolve.

I just checked License file, it looks like there are some file directory is
changed and we need to updated.
And we are not supposed just copy the License Header to the License file,
please check this section[1] for more information.
Most of time you are not supposed to add the ASF License on the top of
third party code.[2]

[1]http://apache.org/dev/licensing-howto.html#permissive-deps
[2]https://www.apache.org/legal/src-headers.html#3party




Willem Jiang

Twitter: willemjiang
Weibo: 姜宁willem

On Thu, Jun 28, 2018 at 6:11 PM, 宁栗 <[email protected]> wrote:

> +1
> Thank you for the release.
>
> 2018-06-27 11:13 GMT+08:00 Jason Xu <[email protected]>:
>
> > +1
> >  Thank you for the release.
> >
> > 2018-06-27 8:02 GMT+08:00 方曦(千之) <[email protected]>:
> >
> > > +1.
> > > Thank you for the release work.
> > >
> > > 发自我的 iPhone
> > >
> > > > 在 2018年6月26日,21:32,申远 <[email protected]> 写道:
> > > >
> > > > +1
> > > > Thank you for the release
> > >
> >
> >
> >
> > --
> > Thanks.
> > Jason Xu
> >
>

Reply via email to