For the LICENSE file, we need to specify the version of chromium, the License information could be different with different version.
Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Thu, Jul 12, 2018 at 9:26 PM, Adam Feng <cxfe...@gmail.com> wrote: > Hi, Willem > > Thanks for your kind advices. > > We have updated the LICENSE file [1] according to [2]，I have checked every > file and directory( android/sdk/ directory will be updated to android_sdk/ > when released) to make sure it is updated correctly and NO ASF License on > the top of third party code. > Please have a check again, If everything is OK，I’ll call another VOTE and > every PPMC member SHOULD specify what they checked and what to resolve. > > [1] https://github.com/apache/incubator-weex/blob/release/LICENSE > [2] http://apache.org/dev/licensing-howto.html#permissive-deps > > Thanks. > Adam Feng > 在 2018年6月30日 +0800 PM5:30，Willem Jiang <willem.ji...@gmail.com>，写道： > > Please don't just add +1 on the vote. > > As the PPMC voting we need to specify what we checked and what kind of > > issue we still need to resolve. > > > > I just checked License file, it looks like there are some file directory > is > > changed and we need to updated. > > And we are not supposed just copy the License Header to the License file, > > please check this section[1] for more information. > > Most of time you are not supposed to add the ASF License on the top of > > third party code.[2] > > > > [1]http://apache.org/dev/licensing-howto.html#permissive-deps > > [2]https://www.apache.org/legal/src-headers.html#3party > > > > > > > > > > Willem Jiang > > > > Twitter: willemjiang > > Weibo: 姜宁willem > > > > On Thu, Jun 28, 2018 at 6:11 PM, 宁栗 <ningli...@gmail.com> wrote: > > > > > +1 > > > Thank you for the release. > > > > > > 2018-06-27 11:13 GMT+08:00 Jason Xu <xuyouyang1...@gmail.com>: > > > > > > > +1 > > > > Thank you for the release. > > > > > > > > 2018-06-27 8:02 GMT+08:00 方曦(千之) <fangxi...@alibaba-inc.com>: > > > > > > > > > +1. > > > > > Thank you for the release work. > > > > > > > > > > 发自我的 iPhone > > > > > > > > > > > 在 2018年6月26日，21:32，申远 <shenyua...@gmail.com> 写道： > > > > > > > > > > > > +1 > > > > > > Thank you for the release > > > > > > > > > > > > > > > > > > > > > -- > > > > Thanks. > > > > Jason Xu > > > > > > > >
