I’ve cloned the whimsy-agenda from github and modified it. Now what? I guess I
need to create a pull request which I’ve never done.
I do have a github account but have always pulled and pushed directly.
So now what?
Craig
[CraigRussell:~/apache/git/whimsy-agenda] clr% git diff
diff --git a/models/minutes.rb b/models/minutes.rb
index 0f610f9..c5cc57f 100755
--- a/models/minutes.rb
+++ b/models/minutes.rb
@@ -60,7 +60,7 @@ class Minutes
if notes and !notes.empty?
[section, title, report, "\n\n" + notes.reflow(7,62)]
elsif report.strip.empty?
- [section, title, report, "\n\n No report was submitted."]
+ [section, title, report, "\n\n No report was received."]
else
[section, title, report, ""]
end
@@ -138,7 +138,7 @@ class Minutes
missing = minutes.scan(/^Attachment (\w\w?):.*\s*\n---/).flatten
missing.each do |attach|
- minutes.sub! /^(\s+)See Attachment #{attach}$/, '\1No report was
submitted.'
+ minutes.sub! /^(\s+)See Attachment #{attach}$/, '\1No report was
received.'
end
minutes.sub! 'Minutes (in Subversion) are found under the URL:',
diff --git a/spec/secretary_spec.rb b/spec/secretary_spec.rb
index dc10ace..620ae49 100644
--- a/spec/secretary_spec.rb
+++ b/spec/secretary_spec.rb
@@ -81,7 +81,7 @@ feature 'report' do
expect(draft).to include('Published minutes can be found at')
expect(draft).to include('approved as submitted by General Consent.')
expect(draft).to include('@Sam: Is anyone on the PMC looking at the
reminders?')
- expect(draft).to include('No report was submitted.')
+ expect(draft).to include('No report was received.')
expect(draft).to include('was approved by Unanimous Vote of the
directors present.')
expect(draft).to match(/Adjourned at \d+:\d\d [ap]\.m\. \(Pacific\)/)
[CraigRussell:~/apache/git/whimsy-agenda] clr% git pull
Already up-to-date.
> On Nov 19, 2015, at 8:47 AM, Sam Ruby <[email protected]> wrote:
>
> On Thu, Nov 19, 2015 at 11:31 AM, Craig L Russell
> <[email protected]> wrote:
>> One of my favorites: no report was submitted.
>>
>> We actually don’t know if a report was submitted and lost in transit.
>> Unlikely, but considering the state of communications, possible.
>>
>> More accurate is: no report was received.
>
> Sounds like an easy change. Being able to run the board agenda tool
> locally as a backup is something you want to explore anyway. Care to
> take a stab at it? I'll share a few pointers to make things easier.
>
> ---
>
> Code where this text is added to draft minutes:
>
> https://github.com/rubys/whimsy-agenda/blob/master/models/minutes.rb#L63
>
> Test for that code:
>
> https://github.com/rubys/whimsy-agenda/blob/master/spec/secretary_spec.rb#L84
>
> - - -
>
> The code for collating board minutes is here:
>
> https://svn.apache.org/repos/private/foundation/board/scripts/collate_minutes.rb
>
> Lines 623 and 626.
>
>> Craig
>
> - Sam Ruby
>
>>> On Nov 18, 2015, at 9:50 PM, Greg Stein <[email protected]> wrote:
>>>
>>>
>>> "No report was submitted" ... I think that isn't clear. Most PMCs don't
>>> submit reports each month. The real message is "A report was expected, but
>>> not submitted". *hand-wave* in nicer messaging.
>>>
>>
>> Craig L Russell
>> Architect, Oracle
>> http://db.apache.org/jdo
>> 408 276-5638 mailto:[email protected]
>> P.S. A good JDO? O, Gasp!
>>
Craig L Russell
Architect, Oracle
http://db.apache.org/jdo
408 276-5638 mailto:[email protected]
P.S. A good JDO? O, Gasp!
