On Fri, Apr 20, 2018 at 7:43 AM, Mike Kienenberger <[email protected]> wrote: > Thanks, Sam. > > Maybe the usability problem is already addressed at this point? If I had > seen "Pending Comment" in the MyFaces section, I would have realized it > needed to be committed. Of course, that assumes that I come back to the > MyFaces agenda page after making the comment, which may not happen. > > Here's a couple of other ideas. > - Send out an email to the commenter if a pending comment still exists after > a certain point of time. (an hour? a day?) > - Commit a placeholder comment to the agenda file along the lines of "There > is a pending comment by mkienenb last modified on 2017-10-01".
Pending comments now should only show on the agenda on which they were entered. As to the usability problem: the Pending Comments text was already there. What I have done for now is to give that text a yellow background to make it more visible, and to make the text hotlink to the queued updates page where they can be submitted. Hopefully this reduces confusion. - Sam Ruby > On 2018/04/20 00:49:59, Sam Ruby <[email protected]> wrote: >> For the moment: ACK. >> >> There are two problems here: the hard one is that usability one. You >> entered a comment and it wasn't obvious to you that the comment had >> not been posted. I need to think about that one. >> >> The second is a much simpler bug. Comments entered on one month's >> agenda shouldn't carry forward to future month's agendas. This is >> partially implemented (enter any comment on any report, and previous >> comments will be discarded). But clearly not fully. I'm traveling at >> the moment, but have a good idea of how to fix this; it may not be >> until early next week that I get to it. >> >> - Sam Ruby >> >> On Thu, Apr 19, 2018 at 11:06 AM, Mike Kienenberger <[email protected]> >> wrote: >> > In the April 2018 agenda, there is comment which I thought I had posted in >> > October for Myfaces. >> > It shows up for me as a pending comment in Mynewt instead. >> > >> > I don't know if the problem was caused by something I did (or did not do) >> > back in October or something in how whimsey is dealing with the comment. >> > >> > At the top of the page, my agenda toolbar shows a red square with a "1" in >> > it. Inspecting it in chrome gives "<li class="label label-danger"><a >> > href="queue">1</a></li>" >> > >> > Clicking on the link takes me to >> > >> > https://whimsy.apache.org/board/agenda/2018-04-18/queue >> > >> > There I'm shown a toolbar labeled "Queued comments" >> > with a link to project Mynewt and my message from October. >> > >> > My only options on the page are "refresh" (does nothing), "commit" (seems >> > like a bad idea), and "go offline" (doesn't seem like it'd help.) >> > >> > I'm no longer subscribed to the <[email protected]> so please cc >> > [email protected] in your responses. Thanks! >> > >> > >>
