On 8 May 2018 at 10:39, Sam Ruby <[email protected]> wrote:
> On Tue, May 8, 2018 at 4:57 AM, sebb <[email protected]> wrote:
>> On 8 May 2018 at 01:39,  <[email protected]> wrote:
>>> This is an automated email from the ASF dual-hosted git repository.
>>>
>>> rubys pushed a commit to branch master
>>> in repository https://gitbox.apache.org/repos/asf/whimsy.git
>>>
>>>
>>> The following commit(s) were added to refs/heads/master by this push:
>>>      new 80a8e74  specify the full path to the repository
>>> 80a8e74 is described below
>>>
>>> commit 80a8e74084a9b216d188e543afe907f87667cd5b
>>> Author: Sam Ruby <[email protected]>
>>> AuthorDate: Mon May 7 20:36:58 2018 -0400
>>>
>>>     specify the full path to the repository
>>> ---
>>>  www/board/agenda/daemon/channel.rb | 4 +++-
>>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/www/board/agenda/daemon/channel.rb 
>>> b/www/board/agenda/daemon/channel.rb
>>> index 8441897..49d567b 100644
>>> --- a/www/board/agenda/daemon/channel.rb
>>> +++ b/www/board/agenda/daemon/channel.rb
>>> @@ -16,7 +16,9 @@ class Channel
>>>    @@sockets = Concurrent::Map.new
>>>    @@users = Concurrent::Map.new {|map,key| map[key]=[]}
>>>
>>> -  FOUNDATION_BOARD = ASF::SVN['foundation_board']
>>> +  # As this tool doesn't load the full whimsy libraries, it can't make use
>>> +  # of niceties like short names... so specify the full path to repository.
>>> +  FOUNDATION_BOARD = ASF::SVN['private/foundation/board']
>>
>> Huh?
>>
>> I temporarily added the following to channel.rb:
>>
>> if __FILE__ == $0 # local testing
>>   puts ASF::SVN['foundation_board']
>> end
>>
>> The following works fine:
>> $ ruby -I /srv/whimsy/lib www/board/agenda/daemon/channel.rb
>
> Ack.  I tried similar things.  Something is different between the
> environment running from the command line and the environment when run
> as a service:
>
> https://github.com/apache/infrastructure-puppet/blob/deployment/modules/whimsy_server/files/board-agenda-websocket.service
>
>> AFAICT the shortcut processing needs whimsy/as/config which is
>> required by session anyway.
>>
>> Are you sure the shortcut causes a failure?
>
> Following is from the syslog:
>
> whimsy-asf-0.0.77/lib/whimsy/asf/svn.rb:60:in `find!': Unable to find
> svn checkout for https://svn.apache.org/repos/foundation_board
> (Exception)

That line number (60) does not agree with the current code.

Maybe the installed version of the library is out of date?

> When the daemon is running, if you go to
> https://whimsy.apache.org/board/agenda, you should see a HTTP status
> of 101 returned from the request
> wss://whimsy.apache.org/board/agenda/websocket/ using the development
> tools from the browser.  If this fails, the daemon is down.
>
> After this change, the daemon started right up.
>
>> If so, I think a different solution is in order.
>>
>>>    # add a new socket/userid pair
>>>    def self.add(ws, id)
>>>
>>> --
>>> To stop receiving notification emails like this one, please contact
>>> [email protected].
>
> - Sam Ruby

Reply via email to