On 8 May 2018 at 11:09, Sam Ruby <[email protected]> wrote: > On Tue, May 8, 2018 at 6:03 AM, sebb <[email protected]> wrote: >> On 8 May 2018 at 10:55, Sam Ruby <[email protected]> wrote: >>> On Tue, May 8, 2018 at 5:45 AM, sebb <[email protected]> wrote: >>>> On 8 May 2018 at 10:39, Sam Ruby <[email protected]> wrote: >>>>> On Tue, May 8, 2018 at 4:57 AM, sebb <[email protected]> wrote: >>>>>> >>>>>> Are you sure the shortcut causes a failure? >>>>> >>>>> Following is from the syslog: >>>>> >>>>> whimsy-asf-0.0.77/lib/whimsy/asf/svn.rb:60:in `find!': Unable to find >>>>> svn checkout for https://svn.apache.org/repos/foundation_board >>>>> (Exception) >>>> >>>> That line number (60) does not agree with the current code. >>> >>> Good catch! >>> >>>> Maybe the installed version of the library is out of date? >>> >>> It certainly is: https://rubygems.org/gems/whimsy-asf/versions/0.0.77, >>> but that shouldn't be used: >>> >>> https://github.com/apache/whimsy/blob/master/www/board/agenda/Gemfile#L3 >>> >>> I could certainly build and push out a new version of whimsy-asf, but >>> that would only be a temporary solution. >> >> I think we need to remove the Gem from the system entirely. > > Then it would fail a different way :-)
That would also need to be fixed. >> I assume most code is not using the Gem otherwise we would have seen >> more issues. >> So it might be feasible to remove it (or at least rename it) and see >> what breaks. >> >> However if there is a way to tell the service to pick up the library >> from the source, that should be added first. > > The way to do that is: > > gem 'whimsy-asf', asf_version, path: File.expand_path(root, __FILE__) > > The question is: why isn't the version_file being found (in the if > statement a few lines before this code) when run as a service? This > file is found when run from the command line. I don't know. Does the library have to be a Gem? Is it not possible to define the RUBY path appropriately so code picks up the source correctly? IMO we should only use Gems for external bundled code. > - Sam Ruby
