On 8/13/07, Eelco Hillenius <[EMAIL PROTECTED]> wrote: > > > there are two choices here - either you document it and let them know > they > > have to properly implement isrequried() in their components - there is > > absolutely nothing wrong with that! > > Requiring clients to let their text fields override isRequired and > call the datepanel for instance? Eeeeewww!
and i suppose requiring a supercall from onattach/onbeforerender/etc is also Eeeeewww! :) but that is how it works. when you override something you have to make sure you do it right. -igor > or if you want to be nice you can do it for them in onattach() instead of > in > > setrequired(). with our new lifecycle in 1.3 first onattach() is called > then > > form.process() so it should always be in sync. > > > > > > See, we can keep bouncing back and forth. I'm ok with the solution we > > > have now (removed final from setRequired). I did override isRequired > > > on the panels where I did override setRequired, so that's tight now. > > > > > > i dont know if i like setrequired() open. what do others think? > > I don't see a problem with it. And like I did with DateField/ > DateTimeField: override setRequired and isRequired, making the latter > final... that's water tight. Works without requiring weird > workarounds. > > Eelco >
