On 8/13/07, Eelco Hillenius <[EMAIL PROTECTED]> wrote: > > > by making setrequired nonfinal the contract you have established is: you > > always have to override both setrequired and isrequired to make sure > they > > return the same value, or call super in setrequired. and you havent done > > this just for the formcomponetpanel but you have leaked this across all > > formcomponents. > > > > i would much rather have datetimefield define the contract on its > factory > > method for newdatetextfield() which 99.9% of people probably wont use. > > You are just nitpicking. 99.9% of people won't override setRequired to > start with.
i dont know about that. seems to me that the majority of people who implement a FormComponentPanel will be forced to overwrite it since that is currently the model you have put in place. i had to do it for formcomponentpanels in my projects, and i really dont like the code it causes. -igor Eelco >
