I've created https://issues.apache.org/jira/browse/WICKET-983 to help out 
reviewing the portlet-support changes.

Although I initially planned to create separate "sub" patches for reviewing the 
important wicket changes individually, this turned out to be a
rather impossible task. The complete size of the full patch is almost 200k and several different issues I needed to solve concerned the same classes/files. Breaking all that up in digestible peaces would cost just to much time to be realistic.

I did however upload a full patch file and provide a short summary of the most 
important changes with links to the specific subtask issues of WICKET-647.
These subtasks provide more detailed descriptions of the issues at hand as well 
as the commit logs of the changes I made.

All committers or otherwise interested: please take some time to at least read 
the description of the problems I needed to solve.
If you see anything you don't like or would have chosen a different solution, 
please bring it up here so we can discuss it.

I would like to merge the portlet support branch into the trunk before the 
-beta4 cutoff, so your input on this is very much appreciated.

Thanks,

Ate Douma


Reply via email to