But that's not just about elements with wicket:id. A <div/> tag _anywhere_ corrupts the DOM tree in firefox. Replacing parts of such tree can have unexpected effects and the problem is very hard to spot.
E.g. when you have markup <div/> something the resulted DOM tree in firefox is <div> something ... which is completely wrong. My question is, what harm does it cause to replace <div /> with <div></div> ? The change would be completely transparent for user and I can't think of anything this would break. -Matej On 11/1/07, Gwyn Evans <[EMAIL PROTECTED]> wrote: > It seems to me that while it's something that Wicket /could/ do, I'm > not sure if it's something that Wicket /should/ do... > > Having said that, I think I'd be less against it if we restricted it > to only tags that had a "wicket:id" attribute? > > /Gwyn > > Thursday, November 1, 2007, 2:18:34 PM, you wrote: > > > It is semanticaly the same. And Firefox really treats <div/> etc. > > wrong way. Should we have a vote on this? > > > -Matej > > > On 11/1/07, Johan Compagner <[EMAIL PROTECTED]> wrote: > >> yeah we are generating extra attributes > >> but do we introduce tags itself ? > >> > >> > >> On 11/1/07, Matej Knopp <[EMAIL PROTECTED]> wrote: > >> > > >> > That's not entirely true. E.g. we generate unique ids for <script> > >> > elements, that is altering markup (this is necessary for header > >> > contribution filtering). > >> > > >> > I don't think it would harm to expend those tags. > >> > > >> > -Matej > >> > > >> > On 11/1/07, Johan Compagner <[EMAIL PROTECTED]> wrote: > >> > > until now we have the policy that we don't alter the markup. > >> > > But we could expand all of them if needed. I don't mind to much > >> > > > >> > > > >> > > On 11/1/07, Matej Knopp <[EMAIL PROTECTED]> wrote: > >> > > > > >> > > > Actually, I think that we might want to do this for all tags except > >> > > > for couple of selected ones, e.g. <hr /> > >> > > > > >> > > > This would also reduce confusion of new user when they do <span > >> > > > wicket:id="label'/> > >> > > > > >> > > > -Matej > >> > > > > >> > > > On 11/1/07, Matej Knopp <[EMAIL PROTECTED]> wrote: > >> > > > > Hi, > >> > > > > > >> > > > > I noticed that if you add empty <div /> tags to firefox, it treats > >> > it > >> > > > > like if you forgot to close it. That can cause weird behavior on > >> > ajax > >> > > > > replacements for example, as it treats the subsequent tags as > >> > children > >> > > > > of the <div /> tag. > >> > > > > > >> > > > > I think we should have a MarkupFilter that replaces all <div /> > >> > > > > tags > >> > > > > with <div></div>. This semes to be also case for <span>, <p>, <b>, > >> > ... > >> > > > > etc. > >> > > > > > >> > > > > -Matej > >> > > > > > >> > > > > >> > > > >> > > >> > > > > -- > Best regards, > Gwyn mailto:[EMAIL PROTECTED] > >
