I will cancel this vote based on what Timo has found. Please let me know, when it has been fixed, so I can build again.
Would it be possible (if you have time) to create a unit test to catch this? There weren't any broken tests when I build it. Frank On Wed, Jan 21, 2009 at 08:25, Igor Vaynberg <[email protected]>wrote: > 1910 was already scheduled for 1.5 with the explanation here: > > > https://issues.apache.org/jira/browse/WICKET-1910?focusedCommentId=12645542#action_12645542 > > so i am +1 for rolling it back. > > i think we should keep 2006 and make appropriate adjustments to wicket > tester. > > -igor > > > On Tue, Jan 20, 2009 at 11:20 PM, Timo Rantalaiho <[email protected]> > wrote: > > Hello again, > > > > At least one project gets working after rolling back just > > the WICKET-1910 changes: > > > > $ svn diff -r 730362:730361 > remove-WICKET-1910.patch > > $ patch -p0 < remove-WICKET-1910.patch > > > > and then there is a smaller issue that for some reason some > > tests (including WicketTesterTest.testExecuteAjaxEvent in > > Wicket core) fail to locate some components on the test page > > because of WICKET-2006 > > > > http://issues.apache.org/jira/browse/WICKET-2006 > > > > http://fisheye6.atlassian.com/changelog/wicket/trunk?cs=731961 > > > > but for that, there is an easy enough workaround of doing > > getSessionSettings().setPageIdUniquePerSession(false); in > > the test Application. > > > > I'll try to make more tests still. > > > > But what do you think, could we roll back WICKET-1910 > > > > https://issues.apache.org/jira/browse/WICKET-1910 > > > > and postpone it to 1.5? > > > > Best wishes, > > Timo > > > > >
