I know we agreed that wicket-1.4 should be a drop-in replacement for 1.3 not requiring any changes to the user code (servlet or wickettester) to work with 1.4, e.g. no changes (except additions) to existing public APIs. But let me quickly explain my thoughts.
It breaks WicketTester but does it break code deployed on a servlet container as well? Please have a look at the change to the test cases. Doesn't it make ajax tests more simple and straight forward? It avoids that we have to code around buggy WicketTester behavior. The question of course is, if that is sufficient enough to break the rule. Any change except javadoc changes change the behavior in one way or another. Hence bug fixes change the behavior as well. Though it is a drop in replacement, the users code might still not work anymore. The only way to make sure that the lastest 1.3 and 1.4 releases are drop in replacements is by applying the change to 1.3 as well. Is that an option? Actually all bugs fixed to 1.4 must than be applied to 1.3 as well. Or do we agree that we are equally strict to 1.3 and really don't want any change that requires any change to any (servlet or wickettester) user code except where it is a severe bug. If that is true than of course it has to be moved to 1.5 The patch consists of two parts. a) Caching if servletwebrequest is an ajax request. b) fix wickettester bug to properly handle ajax requests (discovered by introducing the ajax flag). Obviously we can not have only one. They both only go together. Since subclassing servletwebrequest is an easy thing to do for anybody facing that problem, rolling it back shouldn't be a problem for anybody. But the question to me is: are we strict on not introducing bug fixes which break existing WicketTester based test code (but will work in on servlet containers) and hence do require changes when moving from 1.3 to 1.4. Don't you agree that when moving from 1.3 to 1.4 and extensive review and test of the users code is required anyway? But where do we draw the line. May be it is better to move it to 1.5. I don't mind. I'll revert the change. Juergen
