It's bad practice to check in code that "breaks the build" regardless
of where which branch (or trunk) it's checked into. The code can be
incomplete and not work correctly, but it definitely shouldn't break
the build. I'm not trying to be all "holier-than-thou" or anything.
I've broken our build at work many times (I've always had a good
excuse ;)! The point is that it shouldn't be an expectation that the
trunk's build fails on a regular basis ("don't svn up off a trunk").
It should hopefully be (and is with the Wicket project) a pretty rare
occurrence. I think it's great that the Wicket community has users
who are able and willing to live on the "bleeding edge." I'm sure
Igor was kidding (since he put a little smiley face), but I just
wanted to make sure. :)
On Mon, Jun 22, 2009 at 1:43 PM, Igor Vaynberg <[email protected]> wrote:
>
> if you dont like failures dont svn up off a trunk :)
>
> -igor
>
> On Mon, Jun 22, 2009 at 9:22 AM, Martin Funk<[email protected]> wrote:
> > Beyond that compilation failure I noticed that there are two incarnations of
> > org.apache.wicket.WicketTestCase on in wicket and one in wicket-extensions.
> > They seem so similar, that I fail to see a reason for their double
> > existence.
> >
> > One more I got. The tests are broken for quite a while now:
> > http://wicketstuff.org/teamcity/viewType.html?buildTypeId=bt2&tab=buildTypeStatusDiv
> >
> > Actually I don't really want to be such a pain, but a successful
> > svn update
> > mvn clean install
> > just gives me such a great start in my day that I don't want to miss that.
> >
> > mf
> >
> > Am 22.06.2009 um 17:39 schrieb Igor Vaynberg:
> >
> >> compilation failure is in a test class, looks like someone didnt move
> >> the test case. something that would work in eclipse but not with
> >> maven.
> >>
> >>
> >> http://wicketstuff.org/teamcity/viewLog.html?buildId=4051&tab=buildResultsDiv&buildTypeId=bt2
> >>
> >> -igor
> >>
> >> On Mon, Jun 22, 2009 at 8:32 AM, Juergen
> >> Donnerstag<[email protected]> wrote:
> >>>
> >>> I just did "maven -Dmaven.test.skip=true clean install" and it
> >>> completed successfully (on 1.4 trunk from 18 hrs ago).
> >>>
> >>> -Juergen
> >>>
> >>> On Mon, Jun 22, 2009 at 1:16 PM, Martin Funk<[email protected]> wrote:
> >>>>
> >>>> anyone else bothered by that?
> >>>>
> >>>> mf
> >>>>
> >>>
> >
> >
