Another down side of this is that you can implement your own IStringResourceLoader which does not have to rely on PropertiesFactory for reading properties... I have done that for some applications, and then I end up with some property files which I can (do have, as it is now) write on UTF-8 and some that I cannot... But, of course, that is just a limitation of my own implementation of IStringResourceLoader that i'll try to fix. Best,
Ernesto On Mon, Sep 28, 2009 at 11:42 AM, Johan Compagner <[email protected]>wrote: > -1 then yes > that shouldnt be hardcoded but a property in our settings. > > > On Mon, Sep 28, 2009 at 11:02, Ernesto Reinaldo Barreiro < > [email protected] > > wrote: > > > > [ X] No, don't release it and here is why... > > > > > > > After upgrading to 1.4.2 all my ISO-8859-1 encoded property files fail to > > work. I haven't look into it in detail but I guess this is related to > > * [WICKET-2451] - Add ability to load UTF-8 encoded properties not > > in XML format. > > > > > > I know I shouldn't be using ISO-8859-1... but right now I have a bunch of > > those properties files. Is there an easy way to get around this?.... > After > > looking into changes I see the line (379).... > > > > Reader reader = new InputStreamReader(is, "UTF-8"); > > > > Shouldn't this be cofingurable somehow? > > > > Best, > > > > Ernesto > > > > > > On Mon, Sep 28, 2009 at 2:33 AM, Igor Vaynberg <[email protected] > > >wrote: > > > > > all votes are more then welcome. > > > > > > -igor > > > > > > On Sun, Sep 27, 2009 at 5:20 PM, Sam Stainsby > > > <[email protected]> wrote: > > > > Are non-binding votes preferred or discouraged here? If the former, > > then > > > > after some testing with my projects: > > > > > > > > (nonbinding) > > > > [X] Yes release > > > > [ ] No, don't release it and here is why... > > > > > > > > > > > > > >
