+1 I agree, names like IThing and ThingImpl can be a sign of not thinking too hard about naming things (and even a rush to get coding without enough thought put into design - but that's a long story). For me, dropping those "I" prefixes and any "Impl" suffixes will make the project code-base look even more credible. I don't think we have too many ...Impl's at all (and that's by far the most offensive of these 2 naming anti-patterns). The way to you suggest introducing this improvement to the is my preferred, gentle and step by step, technique too for such a project.
Regards - Cemal jWeekend OO & Java Technologies, Wicket Training and Development http://jWeekend.com PS How about - avoid starting new lines with braces where not absolutely necessary, too? it's OK, I know this will go down like a lead balloon :-) igor.vaynberg wrote: > > we dont do these annoying refactors for no reason. we do not like > something about the code and want to fix it. > > as far as migration pains we can ease that. > > take IRequestCycleProcessor as an example. > > we can create > > interface RequestCycleProcessor extends IRequestCycleProcessor and > deprecate IRequestCycleProcessor. > > release this as 1.5.0.migration jar and then release 1.5.0 with > IRequestCycleProcessor removed. this gives you as much time as you > want to migrate your code. > > -igor > > On Fri, Oct 2, 2009 at 4:14 PM, tetsuo <[email protected]> wrote: >> -1 >> >> It breaks compatibility for absolutely no reason. >> >> >> >> On Fri, Oct 2, 2009 at 7:45 PM, Johan Edstrom <[email protected]> wrote: >> >>> +1 >>> >>> >>> On Oct 2, 2009, at 17:28, Igor Vaynberg <[email protected]> wrote: >>> >>> is it perhaps time to take the I out of our interface names? wicket >>>> has been the only project i have ever worked on/used that follows this >>>> convention, is it time for a change? >>>> >>>> this is not meant as a flamewar about which convention is teh >>>> aw3s0m3st, simply a discussion of whether or not we should switch. >>>> >>>> -igor >>>> >>> >> > > -- View this message in context: http://www.nabble.com/taking-the-I-out-of-Interface-tp25723691p25754608.html Sent from the Wicket - Dev mailing list archive at Nabble.com.
