Although I really like having Weld available, I'm against putting it in 1.5. The RC phase for 1.5 is already taking way too long and adding new functionallity will not make it go faster. Another thing is that the current wicket-weld is still immature. It does work, but the API is not yet crystallized. For example, objects managed by weld are not detached at the end of a request. Other things will probably pop up once we start using it more.
I don't see any reason why Wicket Weld should be part of 1.5 right away. Why can't it be part of wicketstuff for the duration of 1.5 and moved to Wicket with 1.6? Wicketstuff already has the infrastructure for Java 6 and it gives a bit more freedom to change/improve the API in the next few months. Best regards, Emond On Tuesday 23 August 2011 00:11:54 Martijn Dashorst wrote: > Wicket Weld is a really nice to have for wicket 1.5 and would increase > the importance of our release pretty considerably. The issue with > wicket-weld is that it requires java 6, and it is late in the release > game for 1.5 final. > > We have experience with building mixed java releases (see our 1.3 > history), though the build process was not pretty. > > In order to enable wicket-weld we need to do the following IMO: > - create java5 and java6 modules in trunk, each configured with the > correct java version > - commit wicket-weld as a submodule for the java 6 module > - move wicket-examples to java 6 module > - move all other wicket modules to the java 5 module > - fix the wicket parent pom to have a java 5 profile and a java 6 profile > - fix the build script to run different maven setups utilizing a java > 5 home directory and a java 6 home directory > - fix the build script to run java 5 compilation first and then only > java 6 for packaging (without clean) this will keep the java 5 > compiled classes and re-package them during the java 6 run > > This is some work, and as I said, we are late in the release game. If > 1.5 final was this week I wouldn't propose to do this, but perhaps do > it in 1.5.1 or 1.5.2. However, since 1.5-rc6 is still not complete we > might do this now. I'm open to suggestions on whether to include > wicket-weld or not. > > Martijn
