my 2% - introduce interface IHeaderItem (next to abstract class HeaderItem) and use that where possible so migration of existing resources will be easier - rename render(IHeaderResponse) to renderHead(IHeaderResponse) to avoid confusion since 'render(response)' looks to much like it renders all, not just the head. - what happens if you have cyclic dependencies?
Am 03.12.2011 um 17:17 schrieb Igor Vaynberg: > also since we now have HeaderItem and its used in the core part of the > framework (ResourceReference) why not refactor IHeaderResponse to just > have one render(HeaderItem) instead of the ton of methods in there > now... > > -igor > > On Sat, Dec 3, 2011 at 7:29 AM, Igor Vaynberg <[email protected]> wrote: >> looks really good. here are some notes: >> >> * MinifiedDetecting*->MinifiedAware* >> * MinifiedDetecting*#getName() needs to have a code comment saying >> that the code inside has to be threadsafe so when people tweak it they >> are aware of it >> * can the MinifiedDetecting* be made into a wrapper instead of >> different subclasses >> * MinifiedDetecting* doesnt check for the actual file extension, it >> assumes that its either js or css >> * MinifiedDetecting* should warn if minified resource is missing >> >> * ResourceAggrator -> ResourceAggrator >> * ResourceAggrator#renderResources() make sure this is >> infinite-recursion-proof if two dependencies reference each other >> * i dont think getResourceSettings().getUseMinifiedResources() is >> necessary, just use application's developmentmode flag >> >> -igor >> >> On Fri, Dec 2, 2011 at 12:33 AM, Emond Papegaaij >> <[email protected]> wrote: >>> Hi all, >>> >>> For the past few weeks, and especially the last few days, Hielke Hoeve and I >>> have been working on improvements to resource management in Wicket. Most of >>> the improvements are based on work in WiQuery, but the actual implementation >>> is from scratch. The targets for the improvements can be found in >>> WICKET-4273. >>> In short, it boils down to following points: >>> - Dependency support for resources >>> - Sorting of resources in the header >>> - Native resource bundle support in Wicket >>> - Aggregating many small scripts into 1 large script tag, esp. for events >>> >>> The target for these changes will be Wicket 6 and the work in progress can >>> be >>> found on github: >>> https://github.com/papegaaij/wicket/compare/trunk...wicket%2Bwiquery >>> >>> At the moment, all features, except the resource bundles are implemented and >>> working. Documentation is still missing on most places. I've also not yet >>> come >>> to writing tests and an example on how to use it. >>> >>> Please provide your feedback on the code, here on the mailing list or at >>> JIRA. >>> >>> Note to Jeremy: I deleted some of the code you contributed to Wicket 1.5 >>> because there was a large overlap in functionality, and it proved difficult >>> to >>> keep the old code working as is. It would be great if you could shed some >>> light on what the exact problem was, you were trying to solve with that >>> code, >>> so I can make sure that it can also be solved with this new approach. >>> >>> Best regards, >>> Emond Papegaaij
