On Wed, Jul 3, 2013 at 12:20 PM, Emond Papegaaij <[email protected] > wrote:
> [X] Release 6.9.1 with downgrade to jquery 1.8.3, 6.10.0 with jquery > 1.10.1 and migration plugin > > IMHO fixes in patch releases should be as small as possible and as clean > as possible. Reverting a change that broke things should fix those things > again. Using a different strategy (the migration plugin) might break in > other ways we do not yet know and we do not have the time to look for > these breakages. For 6.10 we have plenty of time to test and the > migration plugin should be fine. > 1. I'm not sure whether you had used the migration plugin before but I tried it when fixing wicket-ajax-jquery.js few months ago when testing with 1.9.1 and it didn't help much. I don't want to support it. 2. PLEASE test your apps when a release is being voted. > > Best regards, > Emond > > On Wednesday 03 July 2013 11:12:50 Martijn Dashorst wrote: > > While I typically agree that using the latest stable versions of > > things is a good thing™, in this case the almighty gods that maintain > > jquery have decided to move deprecated APIs from versions prior to 1.9 > > into a migration plugin. In my opinion they did a major booboo to say > > the least, and more accurately they fucked up majorly–YOU DON'T > REMOVE > > PUBLIC API IN A MINOR RELEASE! > > > > Upgrading to wicket 6.9 breaks all our applications that use any > > jquery plugin that was developed in the last decade. I think we should > > not have forcefully upgraded jquery to 1.10.1 in 6.9 (we should've > > caught that though), unless... we forcefully include the jquery > > migration plugin [1] as well in 6.9 (also available for jquery 2.x). > > We can make it so that the migration plugin is enabled by default for > > wicket 6.x applications, and in 7.x by default disabled. > > > > As we are already considering 6.9.1, I think we should fix this issue > > as well in 6.9.1. > > > > [ ] Release 6.9.1 with downgrade to jquery 1.8.3 > > [ ] Release 6.9.1 with jquery 1.10.1 and jquery migration plugin > > [ ] Don't fix jquery issues > > > > WDYT? > > > > Martijn > > > > [1] http://jquery.com/upgrade-guide/1.9/#jquery-migrate-plugin >
