I changed my mind: It's fairly easy to replace the jquery reference for
those who need an older version.
We should have added a hint to the release notes, but regretfully I
wasn't aware of the implications of the jQuery version jump.
So I don't think we need a 6.9.1 (for the jquery problem at least), but
I don't mind a rollback either.
Sven
On 07/03/2013 11:25 AM, Sven Meier wrote:
>MyApp#init() {
> getJavaScriptLibrarySettings().setJQueryReference(new
JavaScriptResourceReference(...,
>anyVersionThatWorksForMeUntilIUpgradeMyAppAndPlugins)) }
Problem is when you're using libraries which are using
JQueryResourceReference.get() hard coded in #getDependencies() :/.
Sven
On 07/03/2013 11:20 AM, Martin Grigorov wrote:
On Wed, Jul 3, 2013 at 12:12 PM, Martijn Dashorst <
[email protected]> wrote:
While I typically agree that using the latest stable versions of
things is a good thing™, in this case the almighty gods that maintain
jquery have decided to move deprecated APIs from versions prior to 1.9
into a migration plugin. In my opinion they did a major booboo to say
the least, and more accurately they fucked up majorly–YOU DON'T REMOVE
PUBLIC API IN A MINOR RELEASE!
Upgrading to wicket 6.9 breaks all our applications that use any
jquery plugin that was developed in the last decade. I think we should
not have forcefully upgraded jquery to 1.10.1 in 6.9 (we should've
caught that though), unless... we forcefully include the jquery
migration plugin [1] as well in 6.9 (also available for jquery 2.x).
We can make it so that the migration plugin is enabled by default for
wicket 6.x applications, and in 7.x by default disabled.
As we are already considering 6.9.1, I think we should fix this issue
as well in 6.9.1.
[ ] Release 6.9.1 with downgrade to jquery 1.8.3
[ ] Release 6.9.1 with jquery 1.10.1 and jquery migration plugin
[ ] Release 6.9.1 with downgrade to jquery 1.8.3, 6.10.0 with jquery
1.10.1 and migration plugin
[X] Don't fix jquery issues
MyApp#init() {
getJavaScriptLibrarySettings().setJQueryReference(new
JavaScriptResourceReference(...,
anyVersionThatWorksForMeUntilIUpgradeMyAppAndPlugins))
}
WDYT?
Martijn
[1] http://jquery.com/upgrade-guide/1.9/#jquery-migrate-plugin
--
Become a Wicket expert, learn from the best: http://wicketinaction.com
