I disagree. The wicket-cdi-1.1 module is not ready. Once it is, I'll move the examples to the new module. Until then, we need the example to be the way we expect our users to use cdi intergration: with wicket-cdi and cdi 1.0. That's why I reverted the examples to wicket-cdi on the wicket-6.x branch.
Best regards, Emond On Wed, Nov 20, 2013 at 8:59 PM, John Sarman <[email protected]> wrote: > The 6.x branch needs the wicket-examples pom updated > > Add > > <dependency> > <groupId>org.jboss.weld.servlet</groupId> > <artifactId>weld-servlet</artifactId> > <version>2.1.0.Final</version> > </dependency> > > Remove > <dependency> > > <groupId>org.jboss.weld</groupId> > <artifactId>weld-core</artifactId> > <version>1.1.9.Final</version> > </dependency> > <dependency> > <groupId>org.jboss.weld.servlet</groupId> > <artifactId>weld-servlet-core</artifactId> > <version>1.1.9.Final</version> > </dependency> > <dependency> > <groupId>org.jboss.seam.conversation</groupId> > <artifactId>seam-conversation-weld</artifactId> > <version>3.0.0.Final</version> > </dependency> > > > Have not tested this. > > John > > > > > > On Wed, Nov 20, 2013 at 2:52 PM, Emond Papegaaij > <[email protected]>wrote: > > > The cdi examples were 'upgraded' to wicket-cdi-1.1 (you can check the > > dependency on wicket-cdi-1.1-weld). > > > > > > On Wed, Nov 20, 2013 at 8:35 PM, Martin Grigorov <[email protected] > > >wrote: > > > > > Did I mention 1.1 ?:-) > > > I say that the CDI example is broken. I think it uses 1.0 > > > On Nov 20, 2013 7:54 PM, "Emond Papegaaij" <[email protected]> > > > wrote: > > > > > > > wicket-cdi-1.1 is in a terrible state at the moment. Both in master > and > > > > wicket-6.x. Perhaps we should remove or disable it for now in master > > and > > > > update it once I've done my work on 6.x. > > > > > > > > > > > > On Wed, Nov 20, 2013 at 3:39 PM, Martin Grigorov < > [email protected] > > > > >wrote: > > > > > > > > > JS UI tests run only for master branch (v.7). > > > > > There is no such problem in wicket-6.x. I guess something is not > > merged > > > > to > > > > > master ... > > > > > I'll check it tomorrow if someone else don't do it earlier. > > > > > > > > > > > > > > > On Wed, Nov 20, 2013 at 4:33 PM, Emond Papegaaij < > > > > > [email protected] > > > > > > wrote: > > > > > > > > > > > Hi Martin, > > > > > > > > > > > > Is this on wicket 6 or 7? I'm currently working on a side-branch > of > > > the > > > > > > wicket-6.x branch. This error is fixed in more recent versions of > > > weld, > > > > > so > > > > > > it > > > > > > seems this testcase is using an old version of weld. The next > > version > > > > of > > > > > > weld not even logs a warning anymore, only a debug. > > > > > > > > > > > > Best regards, > > > > > > Emond > > > > > > > > > > > > On Wednesday 20 November 2013 16:26:07 Martin Grigorov wrote: > > > > > > > Hi Emond, > > > > > > > > > > > > > > I guess your recent changes related to CDI broke the Wicket > > > Examples > > > > > > CDI > > > > > > > example. > > > > > > > The JavaScript UI tests fail with: > > > > > > > > > > > > > > org.jboss.weld.exceptions.DefinitionException: WELD-000070 > Simple > > > > > > bean > > > > > > > [EnhancedAnnotatedTypeImpl] class > > > > > > > org.apache.wicket.devutils.debugbar.DebugBar$3 cannot be a non- > > > > > > static inner > > > > > > > class > > > > > > > at > > > > > > > > > > > > > > > > > > > > > > > > > > > > org.jboss.weld.injection.producer.BasicInjectionTarget.checkType(BasicInjec > > > > > > t > > > > > > > ionTarget.java:81) at > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > org.jboss.weld.injection.producer.BasicInjectionTarget.<init>(BasicInjection > > > > > > > Target.java:69) at > > > > > > > > > > > > > > > > > > > > > > > > > > > > org.jboss.weld.injection.producer.BeanInjectionTarget.<init>(BeanInjection > > > > > > Ta > > > > > > > rget.java:52) at > > > > > > > > > > > > > > > > > > > > > > > > > > > > org.jboss.weld.manager.InjectionTargetFactoryImpl.createInjectionTarget(Inj > > > > > > e > > > > > > > ctionTargetFactoryImpl.java:95) > > > > > > > > > > > > > > This is related to the problem that led to Wicket 6.9.1 > release. > > > > > > > > > > > > > > Please fix it as you find appropriate. > > > > > > > > > > > > > > > > > > > > > > > > > > >
