if the CachingStrategy is FilenameWithVersionResourceCachingStrategy (default)

BasicResourceReferenceMapper # mapHandler 
        --> getCachingStrategy().decorateUrl(resourceUrl, cacheable);
                --> FilenameWithVersionResourceCachingStrategy # decorateUrl()  
                        --> CachingResourceVersion # getVersion() 
                                --> resource.getCacheKey()
                                        --> ConcatBundleResource # getCacheKey()
                                                --> PackageResource # 
getCacheKey() has been modified in the commit 
950df6c24196680a48646ff92b3d959f4985a238 "Improved PackageResource#getCacheKey" 
done on the 3/1/2016
                                                        --> PackageResource # 
exists()
                                                                        String 
absolutePath = Packages.absolutePath(scope, path) is wrong 
                                                                        for the 
footer.css the absolutePath is 
                                                                        
org/apache/wicket/examples/resourcedecoration/org/apache/wicket/examples/resourcedecoration/footer.css
                                                --> then ConcatBundleResource # 
getCacheKey() return null
                                                        --> 
ConcatBundleResource # reportError is called

With the NoOpResourceCachingStrategy, decorateUrl does nothing, so there is no 
problem.

Francois
                                





Le 5 janv. 2016 à 09:58, martin-g <g...@git.apache.org> a écrit :

> Github user martin-g commented on the pull request:
> 
>    https://github.com/apache/wicket/pull/154#issuecomment-168938119
> 
>    It is interesting to find how this got broken.
>    Do you have time to `git bisect` it ?
>    I'll be able to do it as soon as next week.
> 
> 
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---

Reply via email to