Github user PhantomYdn commented on the pull request:
https://github.com/apache/wicket/pull/164#issuecomment-217743743
1. It's subject to what instrument and what shouldn't. Right now all Page
methods are being instrumented. If needed configuration might be stored
somewhere: for example in MonitoringSettings and IClassResolver will use it to
instrument just needed methods.
2. The most tricky point here: how instumented classes interact with the
same class but not instrumented. I think if they devided by user sessions (for
example only if monitoring=true set for me - only pages for my session should
be instrumented) interaction is almost absent.
3. Sure. In other words: javassist is quite low level (but not so low as
gclib or asm:)). So it depends only on you how to represent configuration in
most useful way. I think we might have some XML file with definition of what
classes should be instrumented, methods and what to measure. Then these metrics
might be enabled or disabled in some MonitoringSettings
4. See above.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
