GitHub user bollinger opened a pull request:

    https://github.com/apache/wicket/pull/173

    Bugfix: Ajax add header mangling

    When an ajax update adds a new header css link, the client side javascript 
incorrectly adds attributes "id" and "type".
    
    expected header
    ```
    <head>
      <link href="status.css" rel="stylesheet">
    </head>
    ```
    
    before fix, the header is 
    ```
    <head>
      <link type="null" href="status.css" rel="stylesheet" id="null">
    </head>
    ```
    
    
    The fix is to only add the attributes supplied by the server.
    
    see https://github.com/bollinger/wicket-style-bug for a quick start which 
demonstrates the problem.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bollinger/wicket master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/wicket/pull/173.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #173
    
----
commit 4a09d2a64c62946517bafbdf37349375bfe4a5aa
Author: Peter Henderson <[email protected]>
Date:   2016-02-12T09:12:24Z

    Removed conflict marker from comment.

commit 59855ac795a178914be5b35ff1871edd059b7976
Author: Peter Henderson <[email protected]>
Date:   2016-07-08T08:21:22Z

    Merge remote-tracking branch 'upstream/master'

commit 29a0d0927ba738bd0ccc6bc807a7ff07220bb31a
Author: Peter Henderson <[email protected]>
Date:   2016-07-08T09:59:40Z

    BugFix: Ajax add header style sheet link mangles it.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to