Github user bollinger commented on a diff in the pull request:
https://github.com/apache/wicket/pull/173#discussion_r70299013
--- Diff:
wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
---
@@ -2117,11 +2117,11 @@
// create link element
var css =
Wicket.Head.createElement("link");
- // copy required attributes
- css.id =
node.getAttribute("id");
- css.rel =
node.getAttribute("rel");
- css.href =
node.getAttribute("href");
- css.type =
node.getAttribute("type");
+ // copy supplied attributes
only.
+ for (var attrIdx = 0; attrIdx <
node.attributes.length; attrIdx++) {
+ var attr =
node.attributes[attrIdx];
+
css.setAttribute(attr.name, attr.value)
+ }
--- End diff --
What is the advantage of using jQuery over direct dom manipulation?
IE 5.5 is dead so using element.attributes is fine?
https://developer.mozilla.org/en-US/docs/Web/API/Element/attributes
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
