GitHub user duesenklipper opened a pull request:

    https://github.com/apache/wicket/pull/188

    Feature/locale format fix

    On some systems (like my desktop ;-) ) there is not one single `Locale`, 
but rather different ones for text and formats. For example, I use `en_US` for 
nearly everything, but `de_DE` for formatting. In this situation, 
`DurationTest` fails, because `DurationTest` correctly uses 
`NumberFormat.getNumberInstance`, which uses 
`Locale.getDefault(Locale.Category.FORMAT)`. `Duration` itself, however, just 
calls `Locale.getDefault()` and thus misses the difference. This patch simply 
fixes `Duration` to use the formatting locale.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/duesenklipper/wicket feature/locale-format-fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/wicket/pull/188.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #188
    
----
commit efff42eb7a1fa5ee85344dc1fef831c85c17a3c9
Author: Carl-Eric Menzel <[email protected]>
Date:   2016-08-09T14:45:46Z

    make Duration use the FORMAT category of a locale

commit 50744f28cdb8d77390e41234ccd5821c43e69464
Author: Carl-Eric Menzel <[email protected]>
Date:   2016-11-07T14:06:06Z

    add test for Duration when default locale and formatting locale differ

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to