Github user martin-g commented on a diff in the pull request:

    https://github.com/apache/wicket/pull/188#discussion_r89272848
  
    --- Diff: 
wicket-util/src/test/java/org/apache/wicket/util/lang/BytesTest.java ---
    @@ -40,10 +40,10 @@
        @Before
        public void before()
        {
    -           defaultLocale = Locale.getDefault();
    +           defaultLocale = Locale.getDefault(Locale.Category.FORMAT);
     
                // these tests run in US locale.
    -           Locale.setDefault(Locale.US);
    +           Locale.setDefault(Locale.Category.FORMAT, Locale.US);
    --- End diff --
    
    Would the test still pass without this change ?
    I.e. if Category.FORMAT is not specified then does it fallback to the 
`generic` locale ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to