GitHub user duesenklipper opened a pull request:
https://github.com/apache/wicket/pull/189
make NoRecordsToolbar use onConfigure/setVisible instead of overridinâ¦
â¦g isVisible
Overriding isVisible is discouraged, visibility should be set just once. I
know the rowcount is cached nowadays, but some time ago this actually bit us
(admittedly in some way that I don't remember now, but I think by getRowCount
being called too early in a request).
If this one is accepted, I'll to the port to 8.x myself.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/duesenklipper/wicket
feature/fix-no-records-toolbar
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/wicket/pull/189.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #189
----
commit 944bad39d95d1d0e02f7ede225e49d4746938f83
Author: Carl-Eric Menzel <[email protected]>
Date: 2016-11-07T12:00:51Z
make NoRecordsToolbar use onConfigure/setVisible instead of overriding
isVisible
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
