I'd like to merge the https://github.com/apache/wicket/pull/237 and then build the M8. Any objection?
On Thu, Oct 19, 2017 at 5:58 PM, Andrea Del Bene <[email protected]> wrote: > Actually the issue is not solved at the moment, but I've found the > culprit. I've written more details on JIRA. > > On Thu, Oct 19, 2017 at 5:29 PM, Andrea Del Bene <[email protected]> > wrote: > >> After investigating the code it looks like the error was introduced by >> commit d2a809262, which is part of WICKET-4201 >> >> On Thu, Oct 19, 2017 at 5:13 PM, Andrea Del Bene <[email protected]> >> wrote: >> >>> I'm bisecting the code base. AFAIK It's something introduced after M5 >>> >>> On Thu, Oct 19, 2017 at 4:38 PM, Francois Meillet < >>> [email protected]> wrote: >>> >>>> Sorry, that was not the latest. >>>> Forget my tcket. >>>> >>>> BTW I add that in the pom = <updatePolicy>always</updatePolicy> >>>> >>>> >>>> François >>>> >>>> >>>> >>>> > Le 19 oct. 2017 à 15:58, Maxim Solodovnik <[email protected]> a >>>> écrit : >>>> > >>>> > So it's not https://issues.apache.org/jira/browse/WICKET-6481 .... >>>> > >>>> > WBR, Maxim >>>> > (from mobile, sorry for the typos) >>>> > >>>> > On Oct 19, 2017 20:55, "Francois Meillet" <[email protected] >>>> > >>>> > wrote: >>>> > >>>> >> this is on the latest snapshot >>>> >> >>>> >> François >>>> >> >>>> >> >>>> >> >>>> >>> Le 19 oct. 2017 à 15:54, Maxim Solodovnik <[email protected]> a >>>> >> écrit : >>>> >>> >>>> >>> This issue might be already fixed, could you please check latest >>>> >> snapshot? >>>> >>> >>>> >>> WBR, Maxim >>>> >>> (from mobile, sorry for the typos) >>>> >>> >>>> >>> On Oct 19, 2017 20:52, "Francois Meillet" < >>>> [email protected]> >>>> >>> wrote: >>>> >>> >>>> >>>> IllegalArgumentException: Argument 'pageClass' may not be null >>>> >>>> >>>> >>>> Dear Dev's >>>> >>>> >>>> >>>> >>>> >>>> Sorry for this one ! https://issues.apache.org/jira >>>> /browse/WICKET-6485 >>>> >>>> >>>> >>>> >>>> >>>> use case : >>>> >>>> >>>> >>>> If I bookmark a stateful page, close the browser, reopen it and >>>> click on >>>> >>>> the bookmark >>>> >>>> I get an IllegalArgumentException >>>> >>>> >>>> >>>> >>>> >>>> java.lang.IllegalArgumentException: Argument 'pageClass' may not >>>> be >>>> >> null. >>>> >>>> at org.apache.wicket.util.lang.Args.notNull(Args.java:41) >>>> >>>> at org.apache.wicket.core.request.mapper. >>>> >> AbstractBookmarkableMapper$ >>>> >>>> UrlInfo.<init>(AbstractBookmarkableMapper.java:90) >>>> >>>> at org.apache.wicket.core.request.mapper. >>>> >> AbstractBookmarkableMapper. >>>> >>>> mapHandler(AbstractBookmarkableMapper.java:410) >>>> >>>> at org.apache.wicket.request.mapper.CompoundRequestMapper. >>>> >> mapHandler( >>>> >>>> CompoundRequestMapper.java:210) >>>> >>>> >>>> >>>> >>>> >>>> François >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>>> Le 19 oct. 2017 à 15:00, Andrea Del Bene <[email protected]> a >>>> >> écrit >>>> >>>> : >>>> >>>>> >>>> >>>>> On Thu, Oct 19, 2017 at 11:06 AM, Thomas Matthijs < >>>> [email protected]> >>>> >>>> wrote: >>>> >>>>> >>>> >>>>>> Would it be possible to include https://github.com/apache/ >>>> >>>> wicket/pull/237 >>>> >>>>>> ? >>>> >>>>>> That is the only major thing that failed when I upgraded from >>>> wicket7 >>>> >>>>>> >>>> >>>>>> The model setter was removed because it required a cast many >>>> years >>>> >>>>>> ago, since the models have been reworked so a cast is no longer >>>> >>>>>> needed. The ListView itself still support modifying it in >>>> multiple >>>> >>>>>> ways with the moveUp/Down links, therefor I don't see any >>>> objections >>>> >>>>>> to adding the setter again >>>> >>>>>> >>>> >>>>>> Thanks >>>> >>>>>> >>>> >>>>> >>>> >>>>> Looks ok to me >>>> >>>>> >>>> >>>>> >>>> >>>>>> >>>> >>>>>> On Thu, Oct 19, 2017 at 10:58 AM, Andrea Del Bene < >>>> >> [email protected] >>>> >>>>> >>>> >>>>>> wrote: >>>> >>>>>>> On Thu, Oct 19, 2017 at 10:33 AM, Martijn Dashorst < >>>> >>>>>>> [email protected]> wrote: >>>> >>>>>>> >>>> >>>>>>>> I say make a final milestone. Work on a press release for >>>> Wicket 8 >>>> >>>>>> final, >>>> >>>>>>>> work with Sally from PR to get the press release in good >>>> shape, cut >>>> >>>> 8.0 >>>> >>>>>> and >>>> >>>>>>>> release it upon the world. >>>> >>>>>>>> >>>> >>>>>>>> Martijn >>>> >>>>>>>> >>>> >>>>>>> >>>> >>>>>>> Absolutely! M8 is meant to be the last milestone before GA. >>>> >>>>>>> >>>> >>>>>>> >>>> >>>>>>>> On Thu, Oct 19, 2017 at 10:14 AM, Andrea Del Bene < >>>> >>>> [email protected] >>>> >>>>>>> >>>> >>>>>>>> wrote: >>>> >>>>>>>> >>>> >>>>>>>>> i dare ask you... :-) >>>> >>>>>>>>> >>>> >>>>>>>> >>>> >>>>>>>> >>>> >>>>>>>> >>>> >>>>>>>> -- >>>> >>>>>>>> Become a Wicket expert, learn from the best: >>>> >>>> http://wicketinaction.com >>>> >>>>>>>> >>>> >>>>>> >>>> >>>> >>>> >>>> >>>> >> >>>> >> >>>> >>>> >>> >> >
