Github user klopfdreh commented on a diff in the pull request:

    https://github.com/apache/wicket/pull/275#discussion_r181286646
  
    --- Diff: 
wicket-core/src/main/java/org/apache/wicket/protocol/http/request/WebClientInfo.java
 ---
    @@ -46,14 +46,20 @@
     
        /**
         * The user agent string from the User-Agent header, app. 
Theoretically, this might differ from
    -    * {@link 
org.apache.wicket.protocol.http.ClientProperties#isNavigatorJavaEnabled()} 
property, which is
    -    * not set until an actual reply from a browser (e.g. using {@link 
BrowserInfoPage} is set.
    +    * {@link 
org.apache.wicket.protocol.http.ClientProperties#isNavigatorJavaEnabled()} 
property,
    +    * which is not set until an actual reply from a browser (e.g. using 
{@link BrowserInfoPage} is
    +    * set.
         */
        private final String userAgent;
     
        /** Client properties object. */
        private final ClientProperties properties;
     
    +   private final static UserAgentAnalyzer UAA = 
UserAgentAnalyzer.newBuilder()
    --- End diff --
    
    The initialization is expensive, but the UserAgentAnalyzer is thread safe 
so it can be reused. Maybe we are able to use MetaDataKey


---

Reply via email to