Github user klopfdreh commented on a diff in the pull request:

    https://github.com/apache/wicket/pull/275#discussion_r181295733
  
    --- Diff: 
wicket-core/src/test/java/org/apache/wicket/protocol/http/request/WebClientInfoTest.java
 ---
    @@ -59,9 +58,52 @@ public void before()
        }
        
        /**
    -    * Test IE 6.x user-agent strings
    +    * Test check check all user agents
         */
        @Test
    +   public void testBrowsersAndVersionsOfUserAgents() {
    +           // Internet Explorers
    --- End diff --
    
    Yes that is true, but I think if you change the code / the browser 
detection you are going to investigate why the test is failing and fix the 
integration as long as every test is back working again.
    
    @BeforeClass is not working, because WicketTestCase and at this stage no 
Application is attached to the main thread.


---

Reply via email to