GitHub user renoth opened a pull request:
https://github.com/apache/wicket/pull/287
Considering upgrading to Junit5
Proof of concept of the upgrade to Junit5:
Thanks for the quick reply, i supplied the changes to WicketTester to
remove the junit4 dependencies, i think TagTester and Formtester also have
junit4 dependencies, ideally Junit would be removed as a dependency altogether
here and some more light-weight assertion framework could be used, maybe
assertj or hamcrest.
i also did the migration to Junit5 in the wicket-util module to show how
the testcode would change. i commented out some tedious refactoring classes,
the remaining tests should run.
As for the pom.xml changes i am not sure if these are correct (especially
in wicket-util)
The removal of Junit as a dependency to WicketTester could also be
considered if it is acceptable to jave AssertJ or Hamcrest or another
validation library as dependency.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/renoth/wicket master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/wicket/pull/287.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #287
----
commit daeab2145d710fe090d6cf419f3859d71f016f0b
Author: renoth <johannes.renoth@...>
Date: 2018-07-31T10:32:49Z
- upgrade junit4 with junit5 in wicket-util
- replace Junit4 Methods in WicketTester.java
- remove junit 4 dependencies in pom.xml
commit 4bc8b6fa79c6ca3ed6d4463340f15f2b22abeed4
Author: renoth <johannes.renoth@...>
Date: 2018-07-31T10:45:28Z
removed import, added some imports
commit 4939c5b3d502c68d1c0bd42f742a071fb22f7580
Author: renoth <johannes.renoth@...>
Date: 2018-07-31T10:46:57Z
commented out some tedious refactorings
----
---
