Github user klopfdreh commented on a diff in the pull request:

    https://github.com/apache/wicket/pull/283#discussion_r239994086
  
    --- Diff: 
wicket-core/src/main/java/org/apache/wicket/DefaultPageManagerProvider.java ---
    @@ -167,6 +168,10 @@ protected IPageStore newPersistentStore()
                Bytes maxSizePerSession = storeSettings.getMaxSizePerSession();
                File fileStoreFolder = storeSettings.getFileStoreFolder();
     
    -           return new DiskPageStore(application.getName(), 
fileStoreFolder, maxSizePerSession, getSerializer());
    +           if (storeSettings.isEncrypted()) {
    --- End diff --
    
    Maybe it would be nice to not make the chain configurable by a field in 
general but to have something more spring like. (Like in case of spring Filters)
    
    They implemented it with a List in which you can add filter at various 
places and they delegate to each other. You can add new filters in between like 
filters.add(0,new MyFilter(...));
    
    WDYT?


---

Reply via email to