Github user klopfdreh commented on a diff in the pull request:

    https://github.com/apache/wicket/pull/283#discussion_r241308791
  
    --- Diff: 
wicket-core/src/main/java/org/apache/wicket/DefaultPageManagerProvider.java ---
    @@ -167,6 +168,10 @@ protected IPageStore newPersistentStore()
                Bytes maxSizePerSession = storeSettings.getMaxSizePerSession();
                File fileStoreFolder = storeSettings.getFileStoreFolder();
     
    -           return new DiskPageStore(application.getName(), 
fileStoreFolder, maxSizePerSession, getSerializer());
    +           if (storeSettings.isEncrypted()) {
    --- End diff --
    
    Well the delegation could be done by a default implementation (for example 
as long as you return a store to delegate to). But I think you are right - the 
store configuration is rather static and because of this the stack is more 
verbose and not worth the effort to make it that configurable.


---

Reply via email to