Hi Sébastien,
On Sun, Apr 21, 2019, 08:04 Sebastien Briquet <[email protected]> wrote: > Hi Martin, Maxim > > @Martin: thank you very much for your commits! > Except for the java 11 javadoc-url related commit, I think it is safe to > cherry-pick other commits to wicket8.x, right? Yes. I think so too. (I'm actually wondering > about the wicket:header-items one) > This one as well. You can check by starting the samples in wicket8.x branch and checking the browser's dev tools console. > > https://github.com/sebfz1/wicket-jquery-ui/commit/e07009f2c543a091976e67ebedbfca75681e5820 > > https://github.com/sebfz1/wicket-jquery-ui/commit/bf381285484af9fa20610c6cd7d1277f9ef2898a > > https://github.com/sebfz1/wicket-jquery-ui/commit/54d18a5ed7f992c080906c00946c62f4bb9fdfe6 > > https://github.com/sebfz1/wicket-jquery-ui/commit/9cc163abe9e386ef1e8bc1b638b96af6fc34d126 > > About Unit Tests, yes you are right there is no tests! :) The idea was - > because spare time is limited of course - to test all features by a demo. > This way users have a demo for each feature which is useful and if there is > an issue, they can report through a github issue. I think it is more > efficient than spending a large amount of time trying to test everything in > a UI framework where the layout is also very important, and very difficult > to test... > Amazing job! :-) This way you had time to provide all these demos! > I fixed the "javadoc is missing" issue I had on my side (somehow my JDK did > not contain the javadoc program. I apt install it again, as well as > openjdk-11-jdk-headless package just to be sure, and it works) > > I also enabled TravisCI job for wicket9.x so snapshots will (should) be > deployed on successful builds from now. > https://travis-ci.org/sebfz1/wicket-jquery-ui/branches > > @Maxim: I merged the MR in wicket8.x and applied the change in wicket9.x. > But it seems that Travis does not deploy wicket8.x branch... :( >
